動けるようにする #1288
Open
動けるようにする #1288
+466
−519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er to the controller
|
@Eraxyso ありがとうございます!
みたいな感じでお願いしたいです |
|
↑prの説明に追記しました |
kaitoyama
approved these changes
Jan 18, 2025
| userSet = userSet.Difference(groupUserSet) | ||
| return userSet.ToSlice(), groups, nil | ||
| } | ||
| // func minimizeUsersAndGroups(users []string, groups []uuid.UUID) ([]string, []uuid.UUID, error) { |
There was a problem hiding this comment.
多分これ、目的はusersをgroupsに含まれないものだけにする関数で、usersとgroupsを保存/更新するときに叩く想定で作ってそうだけど、rolloutだけあれば問題なさそうであれば、コメントアウトじゃなくて削除でもいいかも(gitなので)
| description: 回答したもの(answered)か未回答のもの(unanswered)かを選別 | ||
| schema: | ||
| $ref: "#/components/schemas/AnsweredType" | ||
| # answeredInQuery: |
There was a problem hiding this comment.
この辺は使ってなかったからコメントアウトした感じ?
| args: args{ | ||
| userID: questionnairesTestUserID, | ||
| sort: "", | ||
| search: "", | ||
| pageNum: 100000, | ||
| pageNum: 1, | ||
| onlyTargetingMe: true, | ||
| onlyAdministratedByMe: true, |
There was a problem hiding this comment.
すごい直感に反する命名なので、後でschemaから変えた方が良いかも。今はこれでOK
自分が管理者になっていないもののみ取得 (true), 管理者になっているものも含めてすべて取得 (false)。デフォルトはfalse。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1261
controller testに関する部分はあと #1271 でやります
変更箇所リスト：